Pin pydantic #457
Merged
Pin pydantic #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #457 +/- ##
==========================================
+ Coverage 95.08% 95.17% +0.08%
==========================================
Files 31 31
Lines 4374 4413 +39
==========================================
+ Hits 4159 4200 +41
+ Misses 215 213 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
berland
reviewed
Oct 12, 2023
setup.py
Outdated
| @@ -23,6 +23,7 @@ | |||
| "pyarrow", | |||
| "pyyaml>=5.1", | |||
| "treelib", | |||
| "pydantic<2", | |||
There was a problem hiding this comment.
Since this is an indirect dependency, could you add a comment on when it can be removed again?
Updating to Sphinx 7 will require code changes. Sphinx>7.2 also drops support for python3.8.
Ert pins pydantic<2, but we pull pydantic>=2 through rstcheck. Ert also pins fastapi<0.100, which also depends on pydantic<2.
berland
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
newest pydantic is pulled in by rstcheck. ert requires pydantic<2